[
https://issues.apache.org/jira/browse/BEAM-4087?focusedWorklogId=236905&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-236905
]
ASF GitHub Bot logged work on BEAM-4087:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/19 15:34
Start Date: 03/May/19 15:34
Worklog Time Spent: 10m
Work Description: adude3141 commented on issue #8255: [BEAM-4087]
implement configurable dependency versions
URL: https://github.com/apache/beam/pull/8255#issuecomment-489134456
Currently, I am unsure how to resolve the conversation. From my point of
view, we probably should step back and discuss the validity of BEAM-4087 again.
True, this PR implements more than requested there. Try to recap:
##### expose versions to be readable
This is done as some hacks in build files seems to indicate that this might
be helpful (examples above)
##### Enable overwriting
This is mainly influenced by @kennknowles suggestion on the mailing list (or
better, my understanding thereof) regarding handling of dependencies and
resulting discussion [1] and a proposed solution on how to handle such cases.
##### Adding cli parameter
That's actually requested by that ticket and was available with maven. Which
of course does not imply, it is something which needs to be implemented.
Anyway, there *is* already something as such in place on subprojects [2], so
might indeed be helpful.
##### adding project specific dep versions to that map
Instead of defining them locally in build script, they are exposed. For
whatever that might be useful.
[1]
https://lists.apache.org/thread.html/4de4f53a62e862f249ccb27001fa41a38db478cf1c3fe9d15522c2f5@%3Cdev.beam.apache.org%3E
[2]
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/build.gradle#L24-L27
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 236905)
Time Spent: 3h 40m (was: 3.5h)
> Gradle build does not allow to overwrite versions of provided dependencies
> --------------------------------------------------------------------------
>
> Key: BEAM-4087
> URL: https://issues.apache.org/jira/browse/BEAM-4087
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Affects Versions: 2.5.0
> Reporter: Ismaël Mejía
> Assignee: Michael Luckey
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> In order to test modules with provided dependencies in maven we can execute
> for example for Kafka `mvn verify -Prelease -Dkafka.clients.version=0.9.0.1
> -pl 'sdks/java/io/kafka'` However we don't have an equivalent way to do this
> with gradle because the version of the dependencies are defined locally and
> not in the gradle.properties.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
