[
https://issues.apache.org/jira/browse/BEAM-7220?focusedWorklogId=237092&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-237092
]
ASF GitHub Bot logged work on BEAM-7220:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/19 22:36
Start Date: 03/May/19 22:36
Worklog Time Spent: 10m
Work Description: ihji commented on pull request #8491: [BEAM-7220] add
JavaReadViaImpulse substitution to Java expansion service
URL: https://github.com/apache/beam/pull/8491
The issue I tried to fix with #8396 can be solved by this PR. The problem
was that `Read` transform which generates any other types than those covered by
standard coders causes `ClassCastException`. Currently, `Read` transform is
handled by `FlinkRunner` itself and `WireCoder` for runners only allows
length-prefixed byte array coder for all non-standard types. We can fix
`ClassCastException` by substituting `Read` transforms with `Impulse+DoFn` as
we do in `PortableRunner`.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
<br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/)
| --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 237092)
Time Spent: 10m
Remaining Estimate: 0h
> add JavaReadViaImpulse substitution to Java expansion service
> -------------------------------------------------------------
>
> Key: BEAM-7220
> URL: https://issues.apache.org/jira/browse/BEAM-7220
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Read transform is not supported in the portability framework.
> `PortableRunner` substitutes Read transform with Impulse + DoFn before it
> submits a pipeline to JobServer. However, when ExternalTransform is used,
> this substitution logic doesn't work. Looks like it should be done in the
> expansion service instead until we completely remove JavaReadViaImpulse hack.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
