[
https://issues.apache.org/jira/browse/BEAM-7197?focusedWorklogId=237200&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-237200
]
ASF GitHub Bot logged work on BEAM-7197:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/19 13:47
Start Date: 04/May/19 13:47
Worklog Time Spent: 10m
Work Description: adude3141 commented on issue #8495: [DO NOT MERGE]
[BEAM-7197] add @Before to reset static test state
URL: https://github.com/apache/beam/pull/8495#issuecomment-489328593
Run Dataflow PortabilityApi ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 237200)
Time Spent: 0.5h (was: 20m)
> ParDoLifecycleTest: exeption throwing tests broken
> --------------------------------------------------
>
> Key: BEAM-7197
> URL: https://issues.apache.org/jira/browse/BEAM-7197
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Michael Luckey
> Assignee: Michael Luckey
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> ParDoLifecycleTest implements tests to assert that DoFn are tore down after
> another lifecycle method throw an exception.
>
> The implementation uses a static AtomicBoolean for assertions [1].
> Unfortunately, this is never reset which results in that boolean being true
> after the first test which happens to correctly call teardown on exception.
> Failures for tests executed after are essentially hidden.
> This can be seen e.g. by
> {code:bash}
> ./gradlew -p runners/spark/ validatesRunnerBatch --tests
> org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInStartBundle
>
> {code}
> [1]
> https://github.com/apache/beam/blob/master/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoLifecycleTest.java#L407-L412
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
