[
https://issues.apache.org/jira/browse/BEAM-3489?focusedWorklogId=237392&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-237392
]
ASF GitHub Bot logged work on BEAM-3489:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/May/19 10:24
Start Date: 05/May/19 10:24
Worklog Time Spent: 10m
Work Description: thinhha commented on issue #8370: [BEAM-3489] add
PubSub messageId in PubsubMessage
URL: https://github.com/apache/beam/pull/8370#issuecomment-489412588
Thanks - I've added a few changes based on your comment. It's my first PR so
sorry for all the questions!
* For PubsubMesageWithMessageIdCoder, do I need to explicitly skip the
attributes map which is second in pubsub.proto before getting to the message_id
(which is third)?
* Where would be a good place to add some tests for this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 237392)
Time Spent: 40m (was: 0.5h)
> Expose the message id of received messages within PubsubMessage
> ---------------------------------------------------------------
>
> Key: BEAM-3489
> URL: https://issues.apache.org/jira/browse/BEAM-3489
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
> Reporter: Luke Cwik
> Assignee: Thinh Ha
> Priority: Minor
> Labels: newbie, starter
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This task is about passing forward the message id from the pubsub proto to
> the java PubsubMessage.
> Add a message id field to PubsubMessage.
> Update the coder for PubsubMessage to encode the message id.
> Update the translation from the Pubsub proto message to the Dataflow message:
> https://github.com/apache/beam/blob/2e275264b21db45787833502e5e42907b05e28b8/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubUnboundedSource.java#L976
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
