[
https://issues.apache.org/jira/browse/BEAM-6985?focusedWorklogId=237436&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-237436
]
ASF GitHub Bot logged work on BEAM-6985:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/May/19 12:56
Start Date: 05/May/19 12:56
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8453: [BEAM-6985]
TypeHints Py3 Error: Native type compatibility tests fail on Python 3.7+ Updates
URL: https://github.com/apache/beam/pull/8453#discussion_r281019527
##########
File path: sdks/python/apache_beam/typehints/native_type_compatibility.py
##########
@@ -84,19 +84,38 @@ def _safe_issubclass(derived, parent):
issubclass(derived, parent), or False if a TypeError was raised.
"""
try:
- return issubclass(derived, parent)
+ if type(derived) == typing._GenericAlias:
Review comment:
You could consider following to reduce the nesting in try-catch.
```
try:
if hasattr(typing, '_GenericAlias') && (type(derived) ==
typing._GenericAlias):
# Python 3.7+
out = issubclass(derived.__origin__, parent.__origin__)
else:
out = issubclass(derived, parent)
return out
except TypeError:
return False
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 237436)
Time Spent: 20m (was: 10m)
> TypeHints Py3 Error: Native type compatibility tests fail on Python 3.7+
> ------------------------------------------------------------------------
>
> Key: BEAM-6985
> URL: https://issues.apache.org/jira/browse/BEAM-6985
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: niklas Hansson
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The following tests are failing:
> * test_convert_nested_to_beam_type
> (apache_beam.typehints.native_type_compatibility_test.NativeTypeCompatibilityTest)
>
> * test_convert_to_beam_type
> (apache_beam.typehints.native_type_compatibility_test.NativeTypeCompatibilityTest)
>
> * test_convert_to_beam_types
> (apache_beam.typehints.native_type_compatibility_test.NativeTypeCompatibilityTest)
> With similar errors, where `typing.<Type> != <Type>`. eg:
> {noformat}
> FAIL: test_convert_to_beam_type
> (apache_beam.typehints.native_type_compatibility_test.NativeTypeCompatibilityTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/apache_beam/typehints/native_type_compatibility_test.py",
> line 79, in test_convert_to_beam_type
> beam_type, description)
> AssertionError: typing.Dict[bytes, int] != Dict[bytes, int] : simple dict
> {noformat}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
