[
https://issues.apache.org/jira/browse/BEAM-7229?focusedWorklogId=237855&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-237855
]
ASF GitHub Bot logged work on BEAM-7229:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/May/19 15:29
Start Date: 06/May/19 15:29
Worklog Time Spent: 10m
Work Description: adude3141 commented on pull request #8506: [BEAM-7229]
ParDoLifecycleTest: remove duplicated test methods
URL: https://github.com/apache/beam/pull/8506
ParDoLifecycleTest contains following tests:
testTeardownCalledAfterExceptionInStartBundle
testTeardownCalledAfterExceptionInProcessElement
testTeardownCalledAfterExceptionInFinishBundle
testWithContextTeardownCalledAfterExceptionInStartBundle
testWithContextTeardownCalledAfterExceptionInProcessElement
testWithContextTeardownCalledAfterExceptionInFinishBundle
The actual implementation of testTeardownCalledAfterExceptionIn* and the
corresponding counterpart testWithContextTeardownCalledAfterExceptionIn* is
identical.
History shows, there some time has been a DoFnWithContext and a DoFn, which
got renamed to DoFn and OldDoFn at about the time @Setup and @Teardown were
introduced. Seemingly, there has never been a different implementation so
probably on some rebase no the to be merged branch things got messed up. see
[1] and [2]
[1]
https://github.com/apache/beam/commit/12abb1b02246b8d36021c7b1a970daf1b64ba4b9#diff-68ed88cc25171e30985dda4534e68c9b
12abb1b02246b8d36021c7b1a970daf1b64ba4b9
[2]
https://github.com/apache/beam/commit/3bcb6f46ad0ae483d1d8785edc2d9d5846c71a73#diff-68ed88cc25171e30985dda4534e68c9b
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
<br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/)
| --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 237855)
Time Spent: 10m
Remaining Estimate: 0h
> ParDoLifecycleTest: remove duplicated test methods
> --------------------------------------------------
>
> Key: BEAM-7229
> URL: https://issues.apache.org/jira/browse/BEAM-7229
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Michael Luckey
> Assignee: Michael Luckey
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> ParDoLifecycleTest contains following tests:
> testTeardownCalledAfterExceptionInStartBundle
> testTeardownCalledAfterExceptionInProcessElement
> testTeardownCalledAfterExceptionInFinishBundle
> testWithContextTeardownCalledAfterExceptionInSetup
> testWithContextTeardownCalledAfterExceptionInStartBundle
> testWithContextTeardownCalledAfterExceptionInProcessElement
> testWithContextTeardownCalledAfterExceptionInFinishBundle
> The actual implementation of testTeardownCalledAfterExceptionIn* and the
> corresponding counterpart testWithContextTeardownCalledAfterExceptionIn* is
> identical.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
