[
https://issues.apache.org/jira/browse/BEAM-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833955#comment-16833955
]
Alexey Romanenko commented on BEAM-7143:
----------------------------------------
I'm not aware about any specific reasons why these two methods have "update"
prefix. I can only guess that this is because it updates only partly the
consumer/producer config. Probably, [~rangadi] can add something as initial
author of KafkaIO.
On the other hand, I see the reason why "with" prefix can me more evident, so
I'm ok with {{withConsumerConfigOverrides}}. Also, could you do the same for
{{updateProducerProperties}} and add {{withProducerConfigOverrides}} to make it
all consistent?
> adding withConsumerConfigUpdates
> --------------------------------
>
> Key: BEAM-7143
> URL: https://issues.apache.org/jira/browse/BEAM-7143
> Project: Beam
> Issue Type: Improvement
> Components: io-java-kafka
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> To modify `ConsumerConfig` for main consumer, we use
> `updateConsumerProperties`. However, to modify `ConsumerConfig` for offset
> consumer, the right method is `withOffsetConsumerConfigOverrides`. It would
> be good to match both names for improving usability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
