[
https://issues.apache.org/jira/browse/BEAM-7216?focusedWorklogId=237990&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-237990
]
ASF GitHub Bot logged work on BEAM-7216:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/May/19 18:28
Start Date: 06/May/19 18:28
Worklog Time Spent: 10m
Work Description: timrobertson100 commented on issue #8503: [BEAM-7216]
reinstate checks for Kafka client methods
URL: https://github.com/apache/beam/pull/8503#issuecomment-489725205
Thanks @autodidacticon - the code LGTM
It is the [commit message](https://github.com/apache/beam/pull/8503/commits)
format that was incorrect. Can you please rewrite it to `[BEAM-7216] reinstate
checks for Kafka client methods` as the project has a goal of trying to keep
that consistent? I'll then merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 237990)
Time Spent: 50m (was: 40m)
> beam-sdks-java-io-kafka error with kafka brokers < 0.11
> -------------------------------------------------------
>
> Key: BEAM-7216
> URL: https://issues.apache.org/jira/browse/BEAM-7216
> Project: Beam
> Issue Type: Bug
> Components: io-java-kafka
> Affects Versions: 2.10.0, 2.11.0, 2.12.0
> Reporter: Richard Moorhead
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In beam 2.9.0, KafkaRecordCoder was used for both producer/consumer records
> in KafkaIO, in version 2.10.0, ProducerRecordCoder was introduced but it
> appears that in the following code checks are not made to ensure kafka client
> compatibility:
> [https://github.com/apache/beam/blob/master/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ProducerRecordCoder.java#L137]
> Specifically the method call to `headers` will fail for kafka clients < 0.11.
> Elsewhere in this class there are checks on ConsumerSpEL and it is proposed
> that they should be reused in the line referenced.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
