[
https://issues.apache.org/jira/browse/BEAM-5644?focusedWorklogId=238821&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-238821
]
ASF GitHub Bot logged work on BEAM-5644:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/May/19 21:31
Start Date: 07/May/19 21:31
Worklog Time Spent: 10m
Work Description: akedin commented on pull request #7745: [BEAM-5644]
Plugable Planners
URL: https://github.com/apache/beam/pull/7745#discussion_r281833246
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/BeamSqlEnv.java
##########
@@ -73,109 +80,182 @@ public static BeamSqlEnv inMemory(TableProvider...
tableProviders) {
return withTableProvider(inMemoryMetaStore);
}
- private void registerBuiltinUdf(Map<String, List<Method>> methods) {
- for (Map.Entry<String, List<Method>> entry : methods.entrySet()) {
- for (Method method : entry.getValue()) {
- connection.getCurrentSchemaPlus().add(entry.getKey(),
UdfImpl.create(method));
- }
- }
+ public BeamRelNode parseQuery(String query) throws ParseException {
+ return planner.convertToBeamRel(query);
}
- public void addSchema(String name, TableProvider tableProvider) {
- connection.setSchema(name, tableProvider);
+ public boolean isDdl(String sqlStatement) throws ParseException {
+ return planner.parse(sqlStatement) instanceof SqlExecutableStatement;
}
- public void setCurrentSchema(String name) {
- try {
- connection.setSchema(name);
- } catch (SQLException e) {
- throw new RuntimeException(e);
- }
+ public void executeDdl(String sqlStatement) throws ParseException {
+ SqlExecutableStatement ddl = (SqlExecutableStatement)
planner.parse(sqlStatement);
+ ddl.execute(getContext());
}
- /** Register a UDF function which can be used in SQL expression. */
- public void registerUdf(String functionName, Class<?> clazz, String method) {
- connection.getCurrentSchemaPlus().add(functionName, UdfImpl.create(clazz,
method));
+ public CalcitePrepare.Context getContext() {
+ return connection.createPrepareContext();
}
- /** Register a UDF function which can be used in SQL expression. */
- public void registerUdf(String functionName, Class<? extends BeamSqlUdf>
clazz) {
- registerUdf(functionName, clazz, BeamSqlUdf.UDF_METHOD);
+ public Map<String, String> getPipelineOptions() {
+ return connection.getPipelineOptionsMap();
}
- /**
- * Register {@link SerializableFunction} as a UDF function which can be used
in SQL expression.
- * Note, {@link SerializableFunction} must have a constructor without
arguments.
- */
- public void registerUdf(String functionName, SerializableFunction sfn) {
- registerUdf(functionName, sfn.getClass(), "apply");
+ public String explain(String sqlString) throws ParseException {
+ try {
+ return RelOptUtil.toString(planner.convertToBeamRel(sqlString));
+ } catch (Exception e) {
+ throw new ParseException("Unable to parse statement", e);
+ }
}
- /**
- * Register a UDAF function which can be used in GROUP-BY expression. See
{@link
- * org.apache.beam.sdk.transforms.Combine.CombineFn} on how to implement a
UDAF.
- */
- public void registerUdaf(String functionName, Combine.CombineFn combineFn) {
- connection.getCurrentSchemaPlus().add(functionName, new
UdafImpl(combineFn));
- }
+ /** BeamSqlEnv's Builder. */
+ public static class BeamSqlEnvBuilder {
+ private String queryPlannerClassName =
+ "org.apache.beam.sdk.extensions.sql.impl.CalciteQueryPlanner";
- /** Load all UDF/UDAF from {@link UdfUdafProvider}. */
- public void loadUdfUdafFromProvider() {
- ServiceLoader.<UdfUdafProvider>load(UdfUdafProvider.class)
- .forEach(
- ins -> {
- ins.getBeamSqlUdfs().forEach((udfName, udfClass) ->
registerUdf(udfName, udfClass));
- ins.getSerializableFunctionUdfs()
- .forEach((udfName, udfFn) -> registerUdf(udfName, udfFn));
- ins.getUdafs().forEach((udafName, udafFn) ->
registerUdaf(udafName, udafFn));
- });
- }
+ private TableProvider initialTableProvider;
+ private String currentSchemaName;
+ private Map<String, TableProvider> schemaMap = new HashMap<>();
+ private Set<Map.Entry<String, Function>> functionSet = new HashSet<>();
- public void loadBeamBuiltinFunctions() {
- for (BeamBuiltinFunctionProvider provider :
- ServiceLoader.load(BeamBuiltinFunctionProvider.class)) {
- registerBuiltinUdf(provider.getBuiltinMethods());
+ public BeamSqlEnvBuilder setInitializeTableProvider(TableProvider
tableProvider) {
Review comment:
This is not optional, this should be a part of the builder constructor
probably so that it's impossible to miss. And it's unclear why this is initial
if there are no obvious ways to update it (the only other method to update it
is called `addSchema` which is confusing). Rename to something like
`setDefaultSchema()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 238821)
Time Spent: 11h 10m (was: 11h)
> make Planner configurable
> --------------------------
>
> Key: BEAM-5644
> URL: https://issues.apache.org/jira/browse/BEAM-5644
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 11h 10m
> Remaining Estimate: 0h
>
> We can make planner configurable here:
> [BeamQueryPlanner.java#L145|https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/BeamQueryPlanner.java#L145]
>
> By doing so, we can have different planner implementation to support
> different SQL dialect.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
