[
https://issues.apache.org/jira/browse/BEAM-7228?focusedWorklogId=239218&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-239218
]
ASF GitHub Bot logged work on BEAM-7228:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/19 14:15
Start Date: 08/May/19 14:15
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #8528: [BEAM-7228]
Add a Jenkins job running ValidatesRunner tests for Direct runner
URL: https://github.com/apache/beam/pull/8528#discussion_r282086287
##########
File path:
.test-infra/jenkins/job_PostCommit_Java_ValidatesRunner_Direct.groovy
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import PostcommitJobBuilder
+
+
+// This job runs the suite of ValidatesRunner tests against the Direct
+// runner compiled with Java 8.
+PostcommitJobBuilder.postCommitJob('beam_PostCommit_Java_ValidatesRunner_Direct',
+ 'Run Direct ValidatesRunner in Java', 'Direct Runner ValidatesRunner
Tests for Java', this) {
Review comment:
nit: can you please rename the invocation command to 'Run Direct
ValidatesRunner' to be consistent with the other runners.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 239218)
Time Spent: 50m (was: 40m)
> A way to invoke DirectRunner ValidatesRunner in Java 8 tests in the CI
> ----------------------------------------------------------------------
>
> Key: BEAM-7228
> URL: https://issues.apache.org/jira/browse/BEAM-7228
> Project: Beam
> Issue Type: Improvement
> Components: build-system, runner-direct
> Reporter: Ismaël Mejía
> Assignee: Michal Walenia
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> It was recently added a command to run the Direct Runner ValidatesRunner in
> Java 11, however it seems we miss to have the equivalent for the
> ValidatesRunner in Java 8 to be able to do "Run Direct ValidatesRunner"
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
