[
https://issues.apache.org/jira/browse/BEAM-7134?focusedWorklogId=239308&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-239308
]
ASF GitHub Bot logged work on BEAM-7134:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/19 16:46
Start Date: 08/May/19 16:46
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #8526: [BEAM-7134]
Spark portable runner: executable stage sinks should have…
URL: https://github.com/apache/beam/pull/8526#discussion_r282153164
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkTranslationContext.java
##########
@@ -68,4 +69,9 @@ public void computeOutputs() {
dataset.action(); // force computation.
}
}
+
+ /** Generate a unique pCollection id number to identify runner-generated
sinks. */
+ public int getSinkId() {
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 239308)
Time Spent: 0.5h (was: 20m)
> Spark portable runner: executable stage sinks should have unique names
> ----------------------------------------------------------------------
>
> Key: BEAM-7134
> URL: https://issues.apache.org/jira/browse/BEAM-7134
> Project: Beam
> Issue Type: Improvement
> Components: runner-spark
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I realized that I named all the sinks "EmptyOutputSink." This doesn't cause
> any bugs now, but I can see it causing issues in the future. Also, giving the
> sinks unique names helps with debugging.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
