[
https://issues.apache.org/jira/browse/BEAM-6908?focusedWorklogId=240356&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-240356
]
ASF GitHub Bot logged work on BEAM-6908:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/May/19 18:36
Start Date: 10/May/19 18:36
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8518: [BEAM-6908]
Refactor Python performance test groovy file for easy configuration
URL: https://github.com/apache/beam/pull/8518#discussion_r282981925
##########
File path: .test-infra/jenkins/job_PerformanceTests_Python.groovy
##########
@@ -18,46 +18,130 @@
import CommonJobProperties as commonJobProperties
-// This job runs the Beam Python performance tests on PerfKit Benchmarker.
-job('beam_PerformanceTests_Python'){
- // Set default Beam job properties.
- commonJobProperties.setTopLevelMainJobProperties(delegate)
-
- // Run job in postcommit every 6 hours, don't trigger every push.
- commonJobProperties.setAutoJob(
- delegate,
- 'H */6 * * *')
-
- // Allows triggering this build against pull requests.
- commonJobProperties.enablePhraseTriggeringFromPullRequest(
- delegate,
- 'Python SDK Performance Test',
- 'Run Python Performance Test')
-
- def pipelineArgs = [
- project: 'apache-beam-testing',
- staging_location: 'gs://temp-storage-for-end-to-end-tests/staging-it',
- temp_location: 'gs://temp-storage-for-end-to-end-tests/temp-it',
- output: 'gs://temp-storage-for-end-to-end-tests/py-it-cloud/output'
- ]
+
+class PerformanceTestConfigurations {
+ // Name of the Jenkins job
+ String jobName
+ // Description of the Jenkins job
+ String jobDescription
+ // Phrase to trigger this Jenkins job
+ String jobTriggerPhrase
+ // Frequency of the job build, default to every 6 hours
+ String buildSchedule = 'H */6 * * *'
+ // A benchmark flag, will pass to "--benchmarkName"
+ String benchmarkName = 'beam_integration_benchmark'
+ // A benchmark flag, will pass to "--beam_sdk"
+ String sdk = 'python'
+ // A benchmark flag, will pass to "--bigqueryTable"
+ String resultTable
+ // A benchmark flag, will pass to "--beam_it_class"
+ String itClass
+ // A benchmark flag, will pass to "--beam_it_module"
+ String itModule
+ // A benchmark flag, will pass to "--beam_prebuilt"
+ Boolean prebuilt = false
Review comment:
How do we know how to set this flag correctly and what it affects? Is there
a default value we can set so that the user doesn't need to worry about this
knob as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 240356)
Time Spent: 10.5h (was: 10h 20m)
> Add Python3 performance benchmarks
> ----------------------------------
>
> Key: BEAM-6908
> URL: https://issues.apache.org/jira/browse/BEAM-6908
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Similar to
> [beam_PerformanceTests_Python|https://builds.apache.org/view/A-D/view/Beam/view/PerformanceTests/job/beam_PerformanceTests_Python/],
> we want to have a Python3 benchmark running on Jenkins to detect performance
> regression during code adoption.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
