[
https://issues.apache.org/jira/browse/BEAM-6908?focusedWorklogId=240446&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-240446
]
ASF GitHub Bot logged work on BEAM-6908:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/May/19 22:02
Start Date: 10/May/19 22:02
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8518: [BEAM-6908]
Refactor Python performance test groovy file for easy configuration
URL: https://github.com/apache/beam/pull/8518#discussion_r283055250
##########
File path: .test-infra/jenkins/job_PerformanceTests_Python.groovy
##########
@@ -28,25 +28,23 @@ class PerformanceTestConfigurations {
String jobTriggerPhrase
// Frequency of the job build, default to every 6 hours
String buildSchedule = 'H */6 * * *'
- // A benchmark flag, will pass to "--benchmarkName"
+ // A benchmark defined flag, will pass to benchmark as "--benchmarkName"
String benchmarkName = 'beam_integration_benchmark'
- // A benchmark flag, will pass to "--beam_sdk"
- String sdk = 'python'
- // A benchmark flag, will pass to "--bigqueryTable"
+ // A benchmark defined flag, will pass to benchmark as "--bigqueryTable"
String resultTable
- // A benchmark flag, will pass to "--beam_it_class"
+ // A benchmark defined flag, will pass to benchmark as "--beam_it_class"
String itClass
- // A benchmark flag, will pass to "--beam_it_module"
+ // A benchmark defined flag, will pass to benchmark as "--beam_it_module"
String itModule
- // A benchmark flag, will pass to "--beam_prebuilt"
- Boolean prebuilt = false
- // A benchmark flag, will pass to "--beam_python_sdk_location"
+ // A benchmark defined flag, will pass to benchmark as
"--beam_python_sdk_location"
+ // If not provided, benchmark will search through the project recursively
+ // or fails immediately.
Review comment:
Also, where is this recursive search behavior defined?
`getSDKLocationFromModule` seems to look in a particular location?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 240446)
Time Spent: 12h 20m (was: 12h 10m)
> Add Python3 performance benchmarks
> ----------------------------------
>
> Key: BEAM-6908
> URL: https://issues.apache.org/jira/browse/BEAM-6908
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Time Spent: 12h 20m
> Remaining Estimate: 0h
>
> Similar to
> [beam_PerformanceTests_Python|https://builds.apache.org/view/A-D/view/Beam/view/PerformanceTests/job/beam_PerformanceTests_Python/],
> we want to have a Python3 benchmark running on Jenkins to detect performance
> regression during code adoption.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
