[
https://issues.apache.org/jira/browse/BEAM-7154?focusedWorklogId=240840&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-240840
]
ASF GitHub Bot logged work on BEAM-7154:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/19 04:09
Start Date: 13/May/19 04:09
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #8560: [BEAM-7154]
Updating Go SDK errors (Part 3 - Final)
URL: https://github.com/apache/beam/pull/8560
Updating standard Go error functionality (`errors.New` and `fmt.Errorf`) to
use the newly added Beam "errors" package. This PR covers the `core`
subdirectory under `sdks/go/pkg/beam`.
I tried to keep the actual changes as straightforward as possible:
1. If a call isn't wrapping another error, replace it with `New` or
`Errorf`. This should be functionally identical.
2. If a call is wrapping another error, replace it with either `Wrap` or
`WithContext` using my best judgement. I generally used `Wrap` when the wrapped
error originates from third-party code (i.e. any non-Beam package), and I tried
to use `WithContext` otherwise.
3. `WithContext` messages make the most sense in present tense (e.g. "doing
foo", "reading bar"). This means I had to adjust some messages slightly, as
little as I could without losing any useful information.
4. For existing error messages that combined context and errors, I moved the
context part to a separate line using `WithContext`, to improve legibility.
This is the last PR for migrating to the new errors package.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
<br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/)
| --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 240840)
Time Spent: 1.5h (was: 1h 20m)
> Switch internal Go SDK error code to use new package
> ----------------------------------------------------
>
> Key: BEAM-7154
> URL: https://issues.apache.org/jira/browse/BEAM-7154
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> I added a new package for errors in the Go SDK:
> [https://github.com/apache/beam/pull/8369]
> This issue tracks progress on modifying existing error code, which mostly
> uses fmt.Errorf, to use this new package.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
