[
https://issues.apache.org/jira/browse/BEAM-7253?focusedWorklogId=241251&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-241251
]
ASF GitHub Bot logged work on BEAM-7253:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/19 19:47
Start Date: 13/May/19 19:47
Worklog Time Spent: 10m
Work Description: angoenka commented on pull request #8537: [BEAM-7253]
test_with_jar_packages_invalid_file_name test fails on Windows
URL: https://github.com/apache/beam/pull/8537#discussion_r283486557
##########
File path: sdks/python/apache_beam/runners/portability/stager.py
##########
@@ -200,10 +201,11 @@ def stage_job_resources(self,
# Handle jar packages that should be staged for Java SDK Harness.
jar_packages = options.view_as(
DebugOptions).lookup_experiment('jar_packages')
+ classpath_separator = ':' if platform.system() != 'Windows' else ';'
Review comment:
Class path separators are system dependent, for windows it will be `;`
Reference:
https://stackoverflow.com/questions/4528438/classpath-does-not-work-under-linux
However this is just a pipeline option so we can define our own schema and
ask users to provide `;` separated list. The only limitation would be that
users will not be able to have files with `;` in their name which is ok IMO.
To make it more obvious that this is not and actual class path but a list of
jars with separator, I would even recommend `,` as a separator in both windows
and linux.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 241251)
Time Spent: 2h 10m (was: 2h)
> test_with_jar_packages_invalid_file_name test fails on windows
> --------------------------------------------------------------
>
> Key: BEAM-7253
> URL: https://issues.apache.org/jira/browse/BEAM-7253
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> test_with_jar_packages_invalid_file_name test fails on windows. possibly
> different class path separator on windows ";" as compared to linux ":".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
