[
https://issues.apache.org/jira/browse/BEAM-6959?focusedWorklogId=241491&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-241491
]
ASF GitHub Bot logged work on BEAM-6959:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/May/19 03:55
Start Date: 14/May/19 03:55
Worklog Time Spent: 10m
Work Description: angoenka commented on pull request #8531: [BEAM-6959]
Add Flink tests for Go SDK
URL: https://github.com/apache/beam/pull/8531#discussion_r283617284
##########
File path: sdks/go/test/run_integration_tests.sh
##########
@@ -71,21 +130,42 @@ docker images | grep $TAG
# Push the container
gcloud docker -- push $CONTAINER
-DATAFLOW_WORKER_JAR=$(find
./runners/google-cloud-dataflow-java/worker/build/libs/beam-runners-google-cloud-dataflow-java-fn-api-worker-*.jar)
-echo "Using Dataflow worker jar: $DATAFLOW_WORKER_JAR"
+if [[ "$RUNNER" == "dataflow" ]]; then
+ if [[ -z "$DATAFLOW_WORKER_JAR" ]]; then
+ DATAFLOW_WORKER_JAR=$(find
./runners/google-cloud-dataflow-java/worker/build/libs/beam-runners-google-cloud-dataflow-java-fn-api-worker-*.jar)
+ fi
+ echo "Using Dataflow worker jar: $DATAFLOW_WORKER_JAR"
+elif [[ "$RUNNER" == "flink" ]]; then
+ if [[ -z "$ENDPOINT" ]]; then
+ JOB_PORT=$(python ./sdks/python/apache_beam/utils/ports.py)
Review comment:
This will be really hard to maintain as python dev will mostly not know
about this dependency.
Can we write a small shell script method instead of creating go-python
dependency for test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 241491)
Time Spent: 1h 10m (was: 1h)
> Run Go SDK Post Commit tests against the Flink Runner.
> -------------------------------------------------------
>
> Key: BEAM-6959
> URL: https://issues.apache.org/jira/browse/BEAM-6959
> Project: Beam
> Issue Type: Sub-task
> Components: runner-flink, sdk-go, testing
> Reporter: Robert Burke
> Assignee: Kyle Weaver
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> See parent task BEAM-6958
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
