[
https://issues.apache.org/jira/browse/BEAM-7286?focusedWorklogId=241658&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-241658
]
ASF GitHub Bot logged work on BEAM-7286:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/May/19 10:14
Start Date: 14/May/19 10:14
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on pull request #8570:
[BEAM-7286] RedisIO support for INCR/DECR operations
URL: https://github.com/apache/beam/pull/8570#discussion_r283718248
##########
File path:
sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java
##########
@@ -450,7 +450,13 @@ public void processElement(ProcessContext context) {
SADD,
/** Use PFADD command. Insert value in a HLL structure. Create key if it
doesn't exist */
- PFADD
+ PFADD,
+
+ /** Use INC command. Increment counter value of a key by a given value.
*/
+ INCR,
Review comment:
Please, rename it to `INCRBY` because it uses `pipeline.incrBy()` internally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 241658)
Time Spent: 1h 10m (was: 1h)
> RedisIO support for INCR/DECR operations
> ----------------------------------------
>
> Key: BEAM-7286
> URL: https://issues.apache.org/jira/browse/BEAM-7286
> Project: Beam
> Issue Type: Improvement
> Components: io-java-redis
> Affects Versions: 2.12.0
> Reporter: Varun Dhussa
> Assignee: Varun Dhussa
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> An analytics use-case may require streaming INCR / DECR operations to a Redis
> key. These instructions are not currently supported in beam.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
