[ 
https://issues.apache.org/jira/browse/BEAM-7174?focusedWorklogId=241773&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-241773
 ]

ASF GitHub Bot logged work on BEAM-7174:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/May/19 14:58
            Start Date: 14/May/19 14:58
    Worklog Time Spent: 10m 
      Work Description: reuvenlax commented on issue #8425: [BEAM-7174] Add 
schema modification transforms
URL: https://github.com/apache/beam/pull/8425#issuecomment-492274692
 
 
   About your concern w.r.t. field ordering:
   In general I agree with you. Transforms like Select etc. should return 
schemas with the fields in the order selected, and transforms like DropFields 
and RenameFields should preserve the original field order. This requires 
redoing FieldAcessDescriptor as it currently doesn't have enough information to 
preserve this (since it stores top-level fields and nested fields separately). 
This is a general bug, and I just filed BEAM-4076 for us to fix it.
   
   For the AddFields transform it requires a bit more thought. If the user 
calls AddFields("a.b", "c", "a.d"), then we cannot preserve the exact order, as 
a is specified both as the first and the third field. IMO we should let the 
first one win and add in the order [a.[b, d], c]. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 241773)
    Time Spent: 4h  (was: 3h 50m)

> Add transforms for modifying schemas
> ------------------------------------
>
>                 Key: BEAM-7174
>                 URL: https://issues.apache.org/jira/browse/BEAM-7174
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-core
>            Reporter: Reuven Lax
>            Assignee: Reuven Lax
>            Priority: Major
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> We need transforms to add fields, remove fields, and rename fields.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to