[
https://issues.apache.org/jira/browse/BEAM-7305?focusedWorklogId=243282&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-243282
]
ASF GitHub Bot logged work on BEAM-7305:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/May/19 12:16
Start Date: 16/May/19 12:16
Worklog Time Spent: 10m
Work Description: adude3141 commented on pull request #8410: [BEAM-7305]
Add first version of Hazelcast Jet based Java Runner
URL: https://github.com/apache/beam/pull/8410#discussion_r284675684
##########
File path: runners/jet-experimental/build.gradle
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
Review comment:
Not quite sure, if I understand you correctly, @kennknowles
I think, you are referring to archiveBaseName here. It is usually not
necessary to setup on project level. Only if the default seems improper, we are
able (and should) to overwrite.
E.g. in this case, the folder path is `runners:jet-experimental` which will
result in artefact named something about `beam-runners-jet-experimemtal`. Now,
we could decide that this is not wanted as after switching from experimental
mode we would like to keep artifact named consistent. So we could add an
```
archivesBaseName = 'beam-runners-jet'
```
More likely in this case though, would be that we like to drop that
`experimental`on the folder name, i.e. move `runners/jet-experimental` to
`runners/jet` and set
```
archivesBaseName = 'beam-runners-jet-experimental'
```
for the time being.
(Hope I got it right)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 243282)
Time Spent: 2h 10m (was: 2h)
> Add first version of Hazelcast Jet Runner
> -----------------------------------------
>
> Key: BEAM-7305
> URL: https://issues.apache.org/jira/browse/BEAM-7305
> Project: Beam
> Issue Type: New Feature
> Components: runner-jet
> Reporter: Maximilian Michels
> Assignee: Jozsef Bartok
> Priority: Major
> Fix For: 2.14.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
