[ 
https://issues.apache.org/jira/browse/BEAM-6985?focusedWorklogId=243601&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-243601
 ]

ASF GitHub Bot logged work on BEAM-6985:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/May/19 19:23
            Start Date: 16/May/19 19:23
    Worklog Time Spent: 10m 
      Work Description: NikeNano commented on issue #8453: [BEAM-6985] 
TypeHints Py3 Error: Native type compatibility tests fail on Python 3.7+ Updates
URL: https://github.com/apache/beam/pull/8453#issuecomment-493199476
 
 
   > Thanks, @NikeNano. #8590 expands on this change. Would you be ok to keep 
the discussion on what needs to happen in that PR? We probably don't need two 
changes.
   
   Sure! 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 243601)
    Time Spent: 5.5h  (was: 5h 20m)

> TypeHints Py3 Error: Native type compatibility tests fail on Python 3.7+
> ------------------------------------------------------------------------
>
>                 Key: BEAM-6985
>                 URL: https://issues.apache.org/jira/browse/BEAM-6985
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: niklas Hansson
>            Priority: Major
>          Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> The following tests are failing:
> * test_convert_nested_to_beam_type 
> (apache_beam.typehints.native_type_compatibility_test.NativeTypeCompatibilityTest)
>  
> * test_convert_to_beam_type 
> (apache_beam.typehints.native_type_compatibility_test.NativeTypeCompatibilityTest)
>  
> * test_convert_to_beam_types 
> (apache_beam.typehints.native_type_compatibility_test.NativeTypeCompatibilityTest)
> With similar errors, where `typing.<Type> != <Type>`. eg:
> {noformat}
>  FAIL: test_convert_to_beam_type 
> (apache_beam.typehints.native_type_compatibility_test.NativeTypeCompatibilityTest)
>  ----------------------------------------------------------------------
>  Traceback (most recent call last):
>  File 
> "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/apache_beam/typehints/native_type_compatibility_test.py",
>  line 79, in test_convert_to_beam_type
>  beam_type, description)
>  AssertionError: typing.Dict[bytes, int] != Dict[bytes, int] : simple dict
> {noformat}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to