[
https://issues.apache.org/jira/browse/BEAM-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841680#comment-16841680
]
Ismaël Mejía commented on BEAM-7338:
------------------------------------
Another reason to do so is that it leaks DBCP into the JDBCIO user classpath
and this disallows him from using older or future versions of the library
withoug conlicts.
> Deprecate PoolableDataSourceProvider from JdbcIO
> ------------------------------------------------
>
> Key: BEAM-7338
> URL: https://issues.apache.org/jira/browse/BEAM-7338
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jdbc
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
>
> `PoolableDataSourceProvider` was introduced as a facility to create a
> `PoolableDataSource` from a `ConnectionConfiguration` in JdbcIO.
> However the current implementation default parameters cannot cover all cases,
> and tweaking the right parameters of the pool is not trivial without exposing
> too many knobs in the API, so given that we have a generic way to do this via
> `withDataSourceProviderFn` we could deprecate and remove this in the future,
> and probably add its use as an example.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
