[
https://issues.apache.org/jira/browse/BEAM-7347?focusedWorklogId=244153&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-244153
]
ASF GitHub Bot logged work on BEAM-7347:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/19 17:15
Start Date: 17/May/19 17:15
Worklog Time Spent: 10m
Work Description: markflyhigh commented on pull request #8602:
[BEAM-7347] Pass dpb_service_zone flag to benchmarks to fix breakage
URL: https://github.com/apache/beam/pull/8602
Benchmarks failed due to a required flag `dpb_service_zone` is introduced to
Perfkit in https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/1915.
Pass a fake value to benchmark to fix current failure and a long-term fix
should make in Perfkit.
+R: @alanmyrvold
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
<br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/)
| --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 244153)
Time Spent: 10m
Remaining Estimate: 0h
> beam_Performance failed with benchmark flag config error
> --------------------------------------------------------
>
> Key: BEAM-7347
> URL: https://issues.apache.org/jira/browse/BEAM-7347
> Project: Beam
> Issue Type: Bug
> Components: test-failures
> Reporter: Mark Liu
> Priority: Critical
> Time Spent: 10m
> Remaining Estimate: 0h
>
> [All|https://builds.apache.org/view/A-D/view/Beam/view/PerformanceTests/]
> performance benchmarks are affected.
> Error log from [latest beam_PerformanceTests_TextIOIT
> run|https://builds.apache.org/view/A-D/view/Beam/view/PerformanceTests/job/beam_PerformanceTests_TextIOIT/2008/console]:
> {code}
> 00:00:24.372 2019-05-17 00:21:24,724 5d6e9583 MainThread
> beam_integration_benchmark(1/1) ERROR Error during benchmark
> beam_integration_benchmark
> 00:00:24.372 Traceback (most recent call last):
> 00:00:24.372 File
> "/home/jenkins/jenkins-slave/workspace/beam_PerformanceTests_TextIOIT/PerfKitBenchmarker/perfkitbenchmarker/pkb.py",
> line 752, in RunBenchmark
> 00:00:24.372 DoProvisionPhase(spec, detailed_timer)
> 00:00:24.372 File
> "/home/jenkins/jenkins-slave/workspace/beam_PerformanceTests_TextIOIT/PerfKitBenchmarker/perfkitbenchmarker/pkb.py",
> line 538, in DoProvisionPhase
> 00:00:24.372 spec.ConstructDpbService()
> 00:00:24.372 File
> "/home/jenkins/jenkins-slave/workspace/beam_PerformanceTests_TextIOIT/PerfKitBenchmarker/perfkitbenchmarker/benchmark_spec.py",
> line 209, in ConstructDpbService
> 00:00:24.372 self.dpb_service = dpb_service_class(self.config.dpb_service)
> 00:00:24.372 File
> "/home/jenkins/jenkins-slave/workspace/beam_PerformanceTests_TextIOIT/PerfKitBenchmarker/perfkitbenchmarker/providers/gcp/gcp_dpb_dataflow.py",
> line 53, in __init__
> 00:00:24.372 super(GcpDpbDataflow, self).__init__(dpb_service_spec)
> 00:00:24.372 File
> "/home/jenkins/jenkins-slave/workspace/beam_PerformanceTests_TextIOIT/PerfKitBenchmarker/perfkitbenchmarker/dpb_service.py",
> line 127, in __init__
> 00:00:24.372 'The flag dpb_service_zone must be provided, for
> provisioning.')
> 00:00:24.372 InvalidFlagConfigurationError: The flag dpb_service_zone must be
> provided, for provisioning.
> {code}
> Seems certain change on
> [PerfkitBenchmarker|https://github.com/GoogleCloudPlatform/PerfKitBenchmarker]
> breaks our
> [beam_integration_benchmark|https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/blob/master/perfkitbenchmarker/linux_benchmarks/beam_integration_benchmark.py].
> However, we may be able to have a quick fix on Beam side.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
