Valentyn Tymofieiev created BEAM-7350:
-----------------------------------------

             Summary: Update Python Datastore example to use v1new Datastore IO
                 Key: BEAM-7350
                 URL: https://issues.apache.org/jira/browse/BEAM-7350
             Project: Beam
          Issue Type: Improvement
          Components: io-python-gcp
            Reporter: Valentyn Tymofieiev


Recently we updated Datastore IO implementation 
https://github.com/apache/beam/pull/8262, and we need to update the example to 
use the 
new implementation.

Some pointers:

New IO: 
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/datastore/v1new/datastoreio.py

Old IO: 
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/datastore/v1/datastoreio.py

Example using old IO: 
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/examples/cookbook/datastore_wordcount.py

Integration test using old IO: 
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/examples/cookbook/datastore_wordcount_it_test.py

Once the integration test is using the new IO, we can also run it on Python3, 
currently it is skipped: 

https://github.com/apache/beam/blob/15deadff871e55676a5f708fee95b49d0688af83/sdks/python/apache_beam/examples/cookbook/datastore_wordcount_it_test.py#L37

cc: [~udim] 




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to