[
https://issues.apache.org/jira/browse/BEAM-7366?focusedWorklogId=245278&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-245278
]
ASF GitHub Bot logged work on BEAM-7366:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/May/19 16:18
Start Date: 20/May/19 16:18
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #8624: [BEAM-7366]
Determine Spotless target based on project's SourceSet
URL: https://github.com/apache/beam/pull/8624#discussion_r285670871
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -818,13 +818,7 @@ class BeamModulePlugin implements Plugin<Project> {
java {
licenseHeader javaLicenseHeader
googleJavaFormat('1.7')
- target project.fileTree(project.projectDir) {
- include '**/*.java'
- exclude '**/archetype-resources/src/**'
- exclude '**/build/generated/**'
- exclude '**/build/generated-src/**'
- exclude '**/build/generated-*-avro-*/**'
- }
+ target project.sourceSets.main.allJava,
project.sourceSets.test.allJava
Review comment:
Just to highlight the key change here; the rest is spotless re-formatting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 245278)
Time Spent: 1h 40m (was: 1.5h)
> Spotless task does not run
> --------------------------
>
> Key: BEAM-7366
> URL: https://issues.apache.org/jira/browse/BEAM-7366
> Project: Beam
> Issue Type: Bug
> Components: build-system, runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Critical
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Somehow spotless is not active anymore. No errors are reported, no
> auto-formatting can be applied. Need to investigate.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
