[
https://issues.apache.org/jira/browse/BEAM-7373?focusedWorklogId=245634&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-245634
]
ASF GitHub Bot logged work on BEAM-7373:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/19 00:11
Start Date: 21/May/19 00:11
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #8632: [BEAM-7373]
Migrating vet runner
URL: https://github.com/apache/beam/pull/8632
This commit migrates a tool used internally at Google that
examines an inputted pipeline and outputs useful diagnostic
information to greatly improve the pipeline's performance.
This is mainly focused around making sure the user code is
properly registered and has shims generated for it, avoiding
the massive slowdown of runtime reflection.
The original author of this code is Robert Burke, with some
changes by me to get the code working here.
Co-authored-by: Robert Burke <[email protected]>
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
<br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/)
| --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 245634)
Time Spent: 10m
Remaining Estimate: 0h
> Migrate Google code for Go SDK "vet runner"
> -------------------------------------------
>
> Key: BEAM-7373
> URL: https://issues.apache.org/jira/browse/BEAM-7373
> Project: Beam
> Issue Type: New Feature
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The "vet runner" is a tool written by [~lostluck] internally for Google that
> is used to evaluate Beam pipelines to check if they are fulfilling the
> requirements needed to perform well. The following are some of the more
> straightforward things that the vet runner checks:
> * If types or functions need to be registered.
> * If shims have been generated for types/functions that need them.
> * Whether all identifiers in the pipeline were exported.
> * Based on the above, whether a pipeline is performant and, if not, what
> needs to be done to make it performant.
> I did not write the original tool but I will be migrating it to the Beam repo
> so that it can be integrated into the universal runner and direct runner,
> probably with a flag.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
