[
https://issues.apache.org/jira/browse/BEAM-5995?focusedWorklogId=245666&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-245666
]
ASF GitHub Bot logged work on BEAM-5995:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/19 01:37
Start Date: 21/May/19 01:37
Worklog Time Spent: 10m
Work Description: udim commented on pull request #8151: [BEAM-5995] add
Jenkins job with GBK Python load tests
URL: https://github.com/apache/beam/pull/8151#discussion_r285811105
##########
File path: .test-infra/jenkins/LoadTestsBuilder.groovy
##########
@@ -22,8 +22,18 @@ import CommonTestProperties.SDK
import CommonTestProperties.TriggeringContext
class LoadTestsBuilder {
- static void loadTest(context, String title, Runner runner, SDK sdk,
Map<String, ?> options, String mainClass, TriggeringContext triggeringContext) {
+ static void loadTests(scope, sdk, testConfigurations, triggeringContext,
test, mode){
Review comment:
Could you add types to the method arguments to be consistent with the rest
of the file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 245666)
Time Spent: 40.5h (was: 40h 20m)
> Create Jenkins jobs to run the load tests
> -----------------------------------------
>
> Key: BEAM-5995
> URL: https://issues.apache.org/jira/browse/BEAM-5995
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Kasia Kucharczyk
> Assignee: Kasia Kucharczyk
> Priority: Major
> Time Spent: 40.5h
> Remaining Estimate: 0h
>
> (/) Add SMOKE test
> Add GBK load tests.
> Add CoGBK load tests.
> Add Pardo load tests.
> Add SideInput tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
