[
https://issues.apache.org/jira/browse/BEAM-6769?focusedWorklogId=246297&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-246297
]
ASF GitHub Bot logged work on BEAM-6769:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/19 18:45
Start Date: 21/May/19 18:45
Worklog Time Spent: 10m
Work Description: pabloem commented on pull request #8621:
[BEAM-6769][BEAM-7327] add it test for writing and reading with bigqu…
URL: https://github.com/apache/beam/pull/8621#discussion_r286171721
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -654,12 +654,17 @@ def apply_WriteToBigQuery(self, transform, pcoll,
options):
return self.apply_PTransform(transform, pcoll, options)
else:
from apache_beam.io.gcp.bigquery_tools import
parse_table_schema_from_json
+ if transform.schema == beam.io.gcp.bigquery.SCHEMA_AUTODETECT \
+ or transform.schema is None:
+ schema = transform.schema
Review comment:
Maybe here we want schema to be none always? that way we don't have to
special case further down?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 246297)
Time Spent: 15h (was: 14h 50m)
> BigQuery IO does not support bytes in Python 3
> ----------------------------------------------
>
> Key: BEAM-6769
> URL: https://issues.apache.org/jira/browse/BEAM-6769
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Juta Staes
> Assignee: Juta Staes
> Priority: Blocker
> Fix For: 2.14.0
>
> Time Spent: 15h
> Remaining Estimate: 0h
>
> In Python 2 you could write bytes data to BigQuery. This is tested in
>
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/big_query_query_to_table_it_test.py#L186]
> Python 3 does not support
> {noformat}
> json.dumps({'test': b'test'}){noformat}
> which is used to encode the data in
>
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/bigquery_tools.py#L959]
>
> How should writing bytes to BigQuery be handled in Python 3?
> * Forbid writing bytes into BigQuery on Python 3
> * Guess the encoding (utf-8?)
> * Pass the encoding to BigQuery
> cc: [~tvalentyn]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
