[ 
https://issues.apache.org/jira/browse/BEAM-7230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845163#comment-16845163
 ] 

Ismaël Mejía commented on BEAM-7230:
------------------------------------

This is the PR [https://github.com/apache/beam/pull/8635/files]

I decided to reduce the whole wrapper hierarchy I had before because even if 
composable and nice it was a bit overkill and specially error-prone. So now 
there is a straightforward implementation of the PoolableDataSourceProvider, I 
also made internal values static to guarantee the single time construction, and 
the 'tricky' part to tackle was to make the method that built the DataSource 
static and synchronized to avoid interleaving of threads because in the write 
case the DoFn is instantiated per thread so I was still having the DataSource 
built multiple times.

> Using JdbcIO creates huge amount of connections
> -----------------------------------------------
>
>                 Key: BEAM-7230
>                 URL: https://issues.apache.org/jira/browse/BEAM-7230
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow
>    Affects Versions: 2.11.0
>            Reporter: Brachi Packter
>            Assignee: Ismaël Mejía
>            Priority: Major
>             Fix For: 2.13.0
>
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> I want to write form DataFlow to GCP cloud SQL, I'm using connection pool, 
> and still I see huge amount of connections in GCP SQL (4k while I set 
> connection pool to 300), and most of them in sleep.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to