[
https://issues.apache.org/jira/browse/BEAM-7365?focusedWorklogId=246641&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-246641
]
ASF GitHub Bot logged work on BEAM-7365:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/May/19 09:32
Start Date: 22/May/19 09:32
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #8646: [BEAM-7365]
Reduces the volume of test data in fastavro branch of
test_dynamic_work_rebalancing_exhaustive to match the volume of avro branch.
URL: https://github.com/apache/beam/pull/8646#discussion_r286397951
##########
File path: sdks/python/apache_beam/io/avroio_test.py
##########
@@ -359,7 +359,7 @@ def compare_split_points(file_name):
source_test_utils.assert_split_at_fraction_exhaustive(splits[0].source)
if self.use_fastavro:
- file_name = self._write_data(count=200, sync_interval=2)
+ file_name = self._write_data(count=5, sync_interval=2)
Review comment:
Could you add sync_interval as an optional (defaulting to None) argument to
_write_data and remove the branching here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 246641)
Time Spent: 40m (was: 0.5h)
> apache_beam.io.avroio_test.TestAvro.test_dynamic_work_rebalancing_exhaustive
> is very slow
> -----------------------------------------------------------------------------------------
>
> Key: BEAM-7365
> URL: https://issues.apache.org/jira/browse/BEAM-7365
> Project: Beam
> Issue Type: Sub-task
> Components: io-python-avro
> Reporter: Robert Bradshaw
> Assignee: Valentyn Tymofieiev
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {noformat}
> $ python setup.py test -s
> apache_beam.io.avroio_test.TestFastAvro.test_dynamic_work_rebalancing_exhaustive
> test_dynamic_work_rebalancing_exhaustive
> (apache_beam.io.avroio_test.TestFastAvro) ... WARNING:root:After 101
> concurrent splitting trials at item #2, observed only failure, giving up on
> this item
> WARNING:root:After 101 concurrent splitting trials at item #21, observed only
> failure, giving up on this item
> WARNING:root:After 101 concurrent splitting trials at item #22, observed only
> failure, giving up on this item
> WARNING:root:After 1014 total concurrent splitting trials, considered only 25
> items, giving up.
> ok
> ----------------------------------------------------------------------
> Ran 1 test in 172.223s
>
> {noformat}
> Compare this with
> {noformat}
> $ python setup.py test -s
> apache_beam.io.avroio_test.TestAvro.test_dynamic_work_rebalancing_exhaustive
> test_dynamic_work_rebalancing_exhaustive
> (apache_beam.io.avroio_test.TestAvro) ... ok
> ----------------------------------------------------------------------
> Ran 1 test in 0.623s
> OK
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
