[
https://issues.apache.org/jira/browse/BEAM-7383?focusedWorklogId=246905&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-246905
]
ASF GitHub Bot logged work on BEAM-7383:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/May/19 19:12
Start Date: 22/May/19 19:12
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #8644: [BEAM-7383]
Adding strict flag to runners to validate with vet runner
URL: https://github.com/apache/beam/pull/8644#discussion_r286623046
##########
File path: sdks/go/pkg/beam/runners/universal/universal.go
##########
@@ -40,6 +41,18 @@ func init() {
// Execute executes the pipeline on a universal beam runner.
func Execute(ctx context.Context, p *beam.Pipeline) error {
+ if !beam.Initialized() {
+ log.Warn(ctx, "Beam has not been initialized. Call beam.Init()
before pipeline construction.")
Review comment:
Portable runners require beam.Init to function at all. It's reasonable to
hard fail here instead of just logging.
The direct runner is a special case, since the pipeline is executed locally
before the function returns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 246905)
Time Spent: 0.5h (was: 20m)
> Add flag enabling vet runner verification for Universal and Direct runners.
> ---------------------------------------------------------------------------
>
> Key: BEAM-7383
> URL: https://issues.apache.org/jira/browse/BEAM-7383
> Project: Beam
> Issue Type: New Feature
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> With the Vet Runner added, add the ability to use it to verify the user's
> pipeline while using the direct or universal runner by enabling some kind of
> flag or option.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
