[
https://issues.apache.org/jira/browse/BEAM-7397?focusedWorklogId=247226&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-247226
]
ASF GitHub Bot logged work on BEAM-7397:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/19 02:00
Start Date: 23/May/19 02:00
Worklog Time Spent: 10m
Work Description: steveniemitz commented on pull request #8662:
[BEAM-7397] Avoid String.format in state namespace key construction
URL: https://github.com/apache/beam/pull/8662
This is a pretty trivial change, but has a nice little perf impact for jobs
that use lots of state. The existing impl generated state keys using
String.format, this changes it to simply use a string concat, which is
significantly faster.
@lukecwik
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
<br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/)
| --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 247226)
Time Spent: 10m
Remaining Estimate: 0h
> Avoid String.format in state namespace construction
> ---------------------------------------------------
>
> Key: BEAM-7397
> URL: https://issues.apache.org/jira/browse/BEAM-7397
> Project: Beam
> Issue Type: Improvement
> Components: runner-core
> Reporter: Steve Niemitz
> Assignee: Steve Niemitz
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I've noticed that for jobs that access state frequently, a percent or two of
> overall CPU time is actually spent calculating the state namespace name.
> StateNamespaces.java uses a String.format for the window namespaces, but
> could simply use a string concatenation to do the same thing with much less
> overhead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
