[
https://issues.apache.org/jira/browse/BEAM-3934?focusedWorklogId=247444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-247444
]
ASF GitHub Bot logged work on BEAM-3934:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/19 14:53
Start Date: 23/May/19 14:53
Worklog Time Spent: 10m
Work Description: iemejia commented on issue #8648: [BEAM-3934] Use try
with resources to close the reader on JavaReadViaImpulse
URL: https://github.com/apache/beam/pull/8648#issuecomment-495253225
@angoenka maybe?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 247444)
Time Spent: 1.5h (was: 1h 20m)
> BoundedReader should be closed in JavaReadViaImpulse#ReadFromBoundedSourceFn
> ----------------------------------------------------------------------------
>
> Key: BEAM-3934
> URL: https://issues.apache.org/jira/browse/BEAM-3934
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Ted Yu
> Assignee: Ismaël Mejía
> Priority: Minor
> Labels: usability
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> {code}
> public void readSoruce(ProcessContext ctxt) throws IOException {
> BoundedSource.BoundedReader<T> reader =
> ctxt.element().createReader(ctxt.getPipelineOptions());
> for (boolean more = reader.start(); more; more = reader.advance()) {
> ctxt.outputWithTimestamp(reader.getCurrent(),
> reader.getCurrentTimestamp());
> }
> }
> {code}
> The BoundedSource.BoundedReader instance should be closed before returning
> from the method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
