[
https://issues.apache.org/jira/browse/BEAM-7406?focusedWorklogId=248313&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-248313
]
ASF GitHub Bot logged work on BEAM-7406:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/19 22:02
Start Date: 24/May/19 22:02
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #8668: [BEAM-7406]
Include slf4j-jdk14 in Dataflow worker uber jar
URL: https://github.com/apache/beam/pull/8668#discussion_r287526383
##########
File path: runners/google-cloud-dataflow-java/worker/legacy-worker/build.gradle
##########
@@ -219,6 +225,25 @@ dependencies {
shadowTest library.java.mockito_core
}
+project.task('validateShadedJarContainsSlf4jJdk14', dependsOn: 'shadowJar') {
Review comment:
worst camel case ever...
:-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 248313)
Time Spent: 50m (was: 40m)
> Dataflow worker does not include logging backend
> ------------------------------------------------
>
> Key: BEAM-7406
> URL: https://issues.apache.org/jira/browse/BEAM-7406
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Affects Versions: 2.10.0, 2.11.0, 2.12.0, 2.13.0
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Critical
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When the Dataflow worker was donated to Beam, a bug was introduced in the
> build so it does not include slf4j-jdk14 so logging is a noop by default. And
> users adding their own could introduce a mutual slf4j / logback loop.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
