[
https://issues.apache.org/jira/browse/BEAM-7426?focusedWorklogId=248648&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-248648
]
ASF GitHub Bot logged work on BEAM-7426:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/May/19 06:41
Start Date: 27/May/19 06:41
Worklog Time Spent: 10m
Work Description: alexvanboxel commented on issue #8689: [BEAM-7426] Add
underscore support on Field lexer
URL: https://github.com/apache/beam/pull/8689#issuecomment-496097642
@reuvenlax this PR would make it possible to use proto field names as they
contain underscores in general. This would make the following code work:
```
.apply(Filter.<FooBar>create().whereFieldName("test_name", u ->
u.equals("abc")))
.apply(Select.fieldNames("test_name"))
.apply(ParDo.of(new DoFn<Row, String>() {
```
It seems that Filter works, but Select doesn't without the fix. Even so, I
think the lexer is too restrictive and needs to be revised later on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 248648)
Time Spent: 20m (was: 10m)
> FieldSpecifierNotationLexer should support underscore as field character
> ------------------------------------------------------------------------
>
> Key: BEAM-7426
> URL: https://issues.apache.org/jira/browse/BEAM-7426
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Alex Van Boxel
> Assignee: Alex Van Boxel
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Underscore is a common used word delimiter in field names, the current
> FieldSpecifierNotationLexer only support alpha-numeric values for field name
> character.
> The upcoming Protobuf schema support will emit underscores in the field
> names, so field names should support underscore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
