[
https://issues.apache.org/jira/browse/BEAM-7436?focusedWorklogId=249063&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-249063
]
ASF GitHub Bot logged work on BEAM-7436:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/May/19 00:39
Start Date: 28/May/19 00:39
Worklog Time Spent: 10m
Work Description: tweise commented on pull request #8696: [BEAM-7436] Use
coder for Flink's encoded key instead of falling back to Kryo
URL: https://github.com/apache/beam/pull/8696#discussion_r287898884
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/FlinkKeyUtils.java
##########
@@ -60,4 +67,37 @@
e);
}
}
+
+ /** The Coder for the Runner's encoded representation of a key. */
+ static class ByteBufferCoder extends StructuredCoder<ByteBuffer> {
Review comment:
Not Flink specific, so maybe move to common/coders package? Perhaps such
coder even already exists elsewhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 249063)
Time Spent: 0.5h (was: 20m)
> Use Beam coder for Flink's encoded key instead of falling back to Kryo
> ----------------------------------------------------------------------
>
> Key: BEAM-7436
> URL: https://issues.apache.org/jira/browse/BEAM-7436
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> There is no need to use a {{GenericTypeInfo}} for the {{ByteBuffer}} instance
> we use to represent the encoded key. Instead of falling back to Flink's Kryo,
> we should include a simple byte array coder and populate the type information
> properly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
