[
https://issues.apache.org/jira/browse/BEAM-3204?focusedWorklogId=250184&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-250184
]
ASF GitHub Bot logged work on BEAM-3204:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/19 14:58
Start Date: 29/May/19 14:58
Worklog Time Spent: 10m
Work Description: lostluck commented on issue #8688: [BEAM-3204]
Clean-up Coder to only contain FunctionSpec removing its usage of
SdkFunctionSpec
URL: https://github.com/apache/beam/pull/8688#issuecomment-496595008
LGTM for the Go change. Yay reduced repetition :D
Edit: clarified comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 250184)
Time Spent: 1h (was: 50m)
> Coders only should have a FunctionSpec, not an SdkFunctionSpec
> --------------------------------------------------------------
>
> Key: BEAM-3204
> URL: https://issues.apache.org/jira/browse/BEAM-3204
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
> Reporter: Kenneth Knowles
> Assignee: Luke Cwik
> Priority: Major
> Labels: portability
> Time Spent: 1h
> Remaining Estimate: 0h
>
> We added environments to coders to account for "custom" coders where it is
> only really possible for one SDK to understand them, like this:
> {code}
> Coder {
> spec: SdkFunctionSpec {
> environment: "java_sdk_docker_container",
> spec: FunctionSpec {
> urn: "beam:coder:java_custom_coder",
> payload: <serialized java bytes>
> }
> }
> }
> {code}
> But a coder must be understood by both the producer of a PCollection and its
> consumers. A coder is not the same as other UDF, though these are
> user-defined.
> A pipeline where either the producer or consumer cannot handle the coder is
> invalid, and we will have to build our cross-language APIs to prevent
> construction of such a pipeline. So we can drop the environment.
> I think there are some folks who want to reserve the ability to add an
> environment later, perhaps, to not pain ourselves into a corner. In this
> case, we can just add a field to Coder.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
