[
https://issues.apache.org/jira/browse/BEAM-5354?focusedWorklogId=250296&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-250296
]
ASF GitHub Bot logged work on BEAM-5354:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/19 17:13
Start Date: 29/May/19 17:13
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #8713: [BEAM-5354] Add
side input nodes to their consumer's parent-scope.
URL: https://github.com/apache/beam/pull/8713#discussion_r288675871
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/translate.go
##########
@@ -128,7 +128,7 @@ func (m *marshaller) addScopeTree(s *ScopeTree) string {
var subtransforms []string
for _, edge := range s.Edges {
- subtransforms = append(subtransforms, m.addMultiEdge(edge))
+ subtransforms = append(subtransforms, m.addMultiEdge(edge)...)
Review comment:
Learning question, does the addition of ... here prevents creation of a new
slice?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 250296)
Time Spent: 40m (was: 0.5h)
> Side Inputs seems to be non-working in the sdk-go
> -------------------------------------------------
>
> Key: BEAM-5354
> URL: https://issues.apache.org/jira/browse/BEAM-5354
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Tomas Roos
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Running the contains example fails with
>
> {code:java}
> Output i0 for step was not found.
> {code}
> This is because of the call to debug.Head (which internally uses SideInput)
> Removing the following line
> [https://github.com/apache/beam/blob/master/sdks/go/examples/contains/contains.go#L50]
>
> The pipeline executes well.
>
> Executed on id's
>
> go-job-1-1536664417610678545
> vs
> go-job-1-1536664934354466938
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
