[
https://issues.apache.org/jira/browse/BEAM-7443?focusedWorklogId=251083&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-251083
]
ASF GitHub Bot logged work on BEAM-7443:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/19 16:34
Start Date: 30/May/19 16:34
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #8641: [BEAM-7443]
Create a BoundedSource -> SDF wrapper in Python SDK
URL: https://github.com/apache/beam/pull/8641#discussion_r289069738
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner.py
##########
@@ -273,6 +281,10 @@ def run_pipeline(self, pipeline, options):
pipeline_options.DirectOptions).direct_runner_bundle_repeat
self._profiler_factory = profiler.Profile.factory_from_options(
options.view_as(pipeline_options.ProfilingOptions))
+
+ if experiments and 'use_sdf_bounded_source' in experiments:
Review comment:
```suggestion
if 'use_sdf_bounded_source' in experiments:
```
You already guarantee that experiments is not `None` when creating the
variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 251083)
Time Spent: 50m (was: 40m)
> BoundedSource->SDF needs a wrapper in Python SDK
> -------------------------------------------------
>
> Key: BEAM-7443
> URL: https://issues.apache.org/jira/browse/BEAM-7443
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
