[
https://issues.apache.org/jira/browse/BEAM-7305?focusedWorklogId=252065&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-252065
]
ASF GitHub Bot logged work on BEAM-7305:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/19 21:13
Start Date: 31/May/19 21:13
Worklog Time Spent: 10m
Work Description: viliam-durina commented on pull request #8699:
[BEAM-7305] Fix issues in and extend documentation for Hazelcast Jet Runner
URL: https://github.com/apache/beam/pull/8699#discussion_r289551291
##########
File path:
runners/jet-experimental/src/main/java/org/apache/beam/runners/jet/processors/AbstractParDoP.java
##########
@@ -247,7 +255,12 @@ private void processBufferedRegularItems(Inbox inbox) {
@Override
public boolean tryProcess() {
- return outputManager.tryFlush();
+ boolean successful = outputManager.tryFlush();
+ if (successful && System.currentTimeMillis() > lastMetricsFlushTime +
metricsFlushPeriod) {
Review comment:
Should use `System.nanoTime`, real-time clock can move back and forth. Also
you can use `nextMetricsFlushTime` and save one add operation for most calls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 252065)
Time Spent: 8h 40m (was: 8.5h)
> Add first version of Hazelcast Jet Runner
> -----------------------------------------
>
> Key: BEAM-7305
> URL: https://issues.apache.org/jira/browse/BEAM-7305
> Project: Beam
> Issue Type: New Feature
> Components: runner-jet
> Reporter: Maximilian Michels
> Assignee: Jozsef Bartok
> Priority: Major
> Fix For: 2.14.0
>
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
