[
https://issues.apache.org/jira/browse/BEAM-6620?focusedWorklogId=254103&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254103
]
ASF GitHub Bot logged work on BEAM-6620:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/19 23:52
Start Date: 04/Jun/19 23:52
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #8762: [WIP]
[BEAM-6620, BEAM-3606] Stop shading by default.
URL: https://github.com/apache/beam/pull/8762
This stops shading guava by default in all modules that don't have a custom
shading configuration which is all modules except for:
* sdks/java/core
* sdks/java/extensions/kryo
* sdks/java/extensions/sql
* sdks/java/extensions/sql/jdbc
* sdks/java/harness
* runners/spark/job-server
* runners/direct-java
* runners/samza/job-server
* runners/google-cloud-dataflow-java/worker
* runners/google-cloud-dataflow-java/worker/legacy-worker
This migrates all modules except for the ones listed above so that:
* publishing is based off of the unshaded jar and the unshaded test jar.
* all intra module dependences use the compile (default) or testCompile
configuration.
* all dependencies within the module to use
compile/testCompile/testRuntimeClasspath instead of
shadow/shadowTest/shadowTestRuntimeClasspath
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/)
| --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
<br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/)
| --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 254103)
Time Spent: 10m
Remaining Estimate: 0h
> Do not relocate guava
> ---------------------
>
> Key: BEAM-6620
> URL: https://issues.apache.org/jira/browse/BEAM-6620
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Affects Versions: 2.11.0
> Reporter: Ismaël Mejía
> Assignee: Luke Cwik
> Priority: Critical
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Once guava use is vendored we have to remove the automatic relocation of
> guava so modules who use guava in their API (e.g. Cassandra or Kinesis) can
> work correctly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
