[
https://issues.apache.org/jira/browse/BEAM-6683?focusedWorklogId=254313&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254313
]
ASF GitHub Bot logged work on BEAM-6683:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/19 11:39
Start Date: 05/Jun/19 11:39
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #8174: [BEAM-6683] add
createCrossLanguageValidatesRunner task
URL: https://github.com/apache/beam/pull/8174#discussion_r290676217
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1633,6 +1653,109 @@ class BeamModulePlugin implements Plugin<Project> {
/**
***********************************************************************************************/
+ // Method to create the crossLanguageValidatesRunnerTask.
+ // The method takes crossLanguageValidatesRunnerConfiguration as parameter.
+ project.ext.createCrossLanguageValidatesRunnerTask = {
+ def config = it ? it as CrossLanguageValidatesRunnerConfiguration : new
CrossLanguageValidatesRunnerConfiguration()
+
+ project.evaluationDependsOn(":sdks:python")
+ project.evaluationDependsOn(":sdks:java:testing:expansion-service")
+ project.evaluationDependsOn(":runners:core-construction-java")
+
+ // Task for launching expansion services
+ def envDir = project.project(":sdks:python").envdir
+ def pythonDir = project.project(":sdks:python").projectDir
+ def javaPort = startingExpansionPortNumber.getAndDecrement()
+ def pythonPort = startingExpansionPortNumber.getAndDecrement()
+ def expansionJar =
project.project(':sdks:java:testing:expansion-service').buildTestExpansionServiceJar.archivePath
+ def expansionServiceOpts = [
+ "group_id": project.name,
+ "java_expansion_service_jar": expansionJar,
+ "java_port": javaPort,
+ "python_virtualenv_dir": envDir,
+ "python_expansion_service_module":
"apache_beam.runners.portability.expansion_service_test",
+ "python_port": pythonPort
+ ]
+ def serviceArgs =
project.project(':sdks:python').mapToArgString(expansionServiceOpts)
+ def setupTask = project.tasks.create(name: config.name+"Setup", type:
Exec) {
+ dependsOn ':sdks:java:container:docker'
+ dependsOn ':sdks:python:container:docker'
+ dependsOn
':sdks:java:testing:expansion-service:buildTestExpansionServiceJar'
+ dependsOn ":sdks:python:installGcpTest"
+ // setup test env
+ executable 'sh'
Review comment:
Even if I change this to `bash` I get the following on my machine:
```
> Task :runners:flink:1.5:job-server:validatesCrossLanguageRunnerSetup FAILED
/Users/max/Dev/beam/sdks/python/scripts/run_expansion_services.sh: line 80:
[: -v: unary operator expected
/Users/max/Dev/beam/sdks/python/scripts/run_expansion_services.sh: line 136:
flock: command not found
> Task :runners:flink:1.5:job-server:validatesCrossLanguageRunnerCleanup
FAILED
/Users/max/Dev/beam/sdks/python/scripts/run_expansion_services.sh: line 80:
[: -v: unary operator expected
/Users/max/Dev/beam/sdks/python/scripts/run_expansion_services.sh: line 136:
flock: command not found
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 254313)
Time Spent: 13.5h (was: 13h 20m)
> Add an integration test suite for cross-language transforms for Flink runner
> ----------------------------------------------------------------------------
>
> Key: BEAM-6683
> URL: https://issues.apache.org/jira/browse/BEAM-6683
> Project: Beam
> Issue Type: Test
> Components: testing
> Reporter: Chamikara Jayalath
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 13.5h
> Remaining Estimate: 0h
>
> We should add an integration test suite that covers following.
> (1) Currently available Java IO connectors that do not use UDFs work for
> Python SDK on Flink runner.
> (2) Currently available Python IO connectors that do not use UDFs work for
> Java SDK on Flink runner.
> (3) Currently available Java/Python pipelines work in a scalable manner for
> cross-language pipelines (for example, try 10GB, 100GB input for
> textio/avroio for Java and Python).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
