[
https://issues.apache.org/jira/browse/BEAM-7450?focusedWorklogId=254473&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254473
]
ASF GitHub Bot logged work on BEAM-7450:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/19 16:38
Start Date: 05/Jun/19 16:38
Worklog Time Spent: 10m
Work Description: jhalaria commented on issue #8718: [BEAM-7450] Add an
unbounded HcatalogIO reader using splittable pardo
URL: https://github.com/apache/beam/pull/8718#issuecomment-499161385
@iemejia - Thank you so much for your feedback.
- I have addressed all of your recommendations from above.
- Removed the extra tracker and used offsetRangeTracker instead.
- Unit test coverage for the PartitionRangeTracker.
- Refined the public API to be HcatalogIO.unbounded()
- This PR only adds an unbounded reads capability. In order for the unit
tests to not continuously poll for new partitions, I had to add a flag to make
the unbounded behave as bounded.
- I will have a subsequent PR that unifies the two readers into one and the
caller can decide which one to use based a flag. If we like this approach, then
we can potentially have just one `reads` API. However the only down side of
doing this would be adding certain checks that allows reading a table even
without partitions which is a requirement for the unbounded reader to work
correctly.
Please have another look at the PR and let me know your feedback. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 254473)
Time Spent: 2h 40m (was: 2.5h)
> Unbounded HCatalogIO Reader using splittable pardos
> ---------------------------------------------------
>
> Key: BEAM-7450
> URL: https://issues.apache.org/jira/browse/BEAM-7450
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Ankit Jhalaria
> Assignee: Ankit Jhalaria
> Priority: Minor
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> # Current version of HcatalogIO is a bounded source.
> # While migrating our jobs to aws, we realized that it would be helpful to
> have an unbounded hcat reader that can behave as an unbounded source and
> polls for new partitions as and when they become available.
> # I have used splittable pardo(s) to do this. There is a flag that can be
> set to treat this as a bounded source which will terminate if that flag is
> set.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
