[ 
https://issues.apache.org/jira/browse/BEAM-7493?focusedWorklogId=254559&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254559
 ]

ASF GitHub Bot logged work on BEAM-7493:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Jun/19 18:26
            Start Date: 05/Jun/19 18:26
    Worklog Time Spent: 10m 
      Work Description: kennknowles commented on issue #8767: [BEAM-7493] Use 
specified archivesBaseName for project dependencies
URL: https://github.com/apache/beam/pull/8767#issuecomment-499200444
 
 
   Actually pretty much every jar was wrong with my initial change, because 
everything already has `archivesBaseName` set by gradle. My preference would be 
to decouple the archivesBaseName from the publishing configuration. But if we 
really want convention over configuration then we just use a different property 
to override it in the modules that want to set it. That way the 
BeamModulePlugin can always override the gradle defaults, and the modules can 
override the BeamModulePlugin defaults.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 254559)
    Time Spent: 1h 20m  (was: 1h 10m)

> beam-sdks-testing-nexmark produces corrupt pom.xml
> --------------------------------------------------
>
>                 Key: BEAM-7493
>                 URL: https://issues.apache.org/jira/browse/BEAM-7493
>             Project: Beam
>          Issue Type: Bug
>          Components: examples-nexmark
>    Affects Versions: 2.13.0
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Blocker
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Steps to reproduce:
> {code}
> ./gradlew -Prelease -Ppublishing 
> :sdks:java:testing:nexmark:publishMavenJavaPublicationTotestPublicationLocalRepository
> {code}
> and if you inspect the pom you will see
> {code}
>    <dependency>
>       <groupId>org.apache.beam</groupId>
>       <artifactId>beam-sdks-java-testing-test-utils</artifactId>
> ...
> {code}
> It appears to be constructed from the directories, but this (and also 
> load-tests) in the {{testing}} directory have their archive base name 
> overridden: 
> https://github.com/apache/beam/blob/master/sdks/java/testing/test-utils/build.gradle#L20
> So after publication, this will result in a dependency not found error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to