[
https://issues.apache.org/jira/browse/BEAM-7141?focusedWorklogId=254799&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254799
]
ASF GitHub Bot logged work on BEAM-7141:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/19 01:09
Start Date: 06/Jun/19 01:09
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #8739: BEAM-7141: add
key value timer callback
URL: https://github.com/apache/beam/pull/8739#discussion_r290990270
##########
File path: sdks/python/apache_beam/runners/common.py
##########
@@ -183,6 +184,8 @@ def __init__(self, obj_to_invoke, method_name):
self.timestamp_arg_name = kw
elif v == core.DoFn.WindowParam:
self.window_arg_name = kw
+ elif v == core.DoFn.KeyParam:
Review comment:
It is possible to do this at pipeline construction time. This will be
similar to how type hints detection happens. (It will be inspection at
execution time vs inspection at construction time.) However we do not have the
machinery in place and I suspect it will make this PR more complicated that it
is intended.
We can start with a execution time error and later on improve it to be a
construction time error. We can do this backward compatibly by failing in
construction time only when input type hints are not in the [K, V] form,
preserving the same functionality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 254799)
Time Spent: 5.5h (was: 5h 20m)
> Expose kv and window parameters for on_timer
> --------------------------------------------
>
> Key: BEAM-7141
> URL: https://issues.apache.org/jira/browse/BEAM-7141
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Affects Versions: 2.12.0
> Reporter: Thomas Weise
> Assignee: Rakesh Kumar
> Priority: Major
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> We would like to have access to key and window inside the timer callback.
> Without, it is also difficult to debug. We run into this while working on
> BEAM-7112
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
