[
https://issues.apache.org/jira/browse/BEAM-6673?focusedWorklogId=255283&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-255283
]
ASF GitHub Bot logged work on BEAM-6673:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/19 17:42
Start Date: 06/Jun/19 17:42
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #8620: [BEAM-6673]
Add schema support to BigQuery reads
URL: https://github.com/apache/beam/pull/8620#discussion_r291295214
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
##########
@@ -1201,6 +1249,30 @@ public TableReference getTable() {
return toBuilder().setKmsKey(kmsKey).build();
}
+ /**
+ * Sets the {@link Row} conversion function.
+ *
+ * <p>Both {@link #withToBeamRowFn(ToBeamRowFunction)} and {@link
+ * #withFromBeamRowFn(FromBeamRowFunction)} must be set to enable
automatic Beam {@link Schema}
+ * support.
+ */
+ @Experimental(Experimental.Kind.SCHEMAS)
+ public TypedRead<T> withToBeamRowFn(ToBeamRowFunction<T> toRowFn) {
Review comment:
Maybe merge WithToBeamRowFn and withFromBeamRowFn into a single method, as
it never makes sense to call just one of them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 255283)
> BigQueryIO.Read should automatically produce schemas
> ----------------------------------------------------
>
> Key: BEAM-6673
> URL: https://issues.apache.org/jira/browse/BEAM-6673
> Project: Beam
> Issue Type: Sub-task
> Components: io-java-gcp
> Reporter: Reuven Lax
> Assignee: Shehzaad Nakhoda
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The output PCollections should contain
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
