[
https://issues.apache.org/jira/browse/BEAM-7274?focusedWorklogId=255290&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-255290
]
ASF GitHub Bot logged work on BEAM-7274:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/19 17:50
Start Date: 06/Jun/19 17:50
Worklog Time Spent: 10m
Work Description: alexvanboxel commented on issue #8690: [BEAM-7274]
Implement the Protobuf schema provider
URL: https://github.com/apache/beam/pull/8690#issuecomment-499599383
ok, I was wondering if I should take action on this. Get it in master and
then rebase the other section.
_/
_/ Alex Van Boxel
On Thu, Jun 6, 2019 at 7:49 PM reuvenlax <[email protected]> wrote:
> *@reuvenlax* commented on this pull request.
> ------------------------------
>
> In
>
sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoRow.java
> <https://github.com/apache/beam/pull/8690#discussion_r291299236>:
>
> > +import javax.annotation.Nullable;
> +import org.apache.beam.sdk.annotations.Experimental;
> +import org.apache.beam.sdk.schemas.Schema;
> +import org.apache.beam.sdk.schemas.SchemaCoder;
> +import org.apache.beam.sdk.transforms.SerializableFunction;
> +import org.apache.beam.sdk.values.Row;
> +import org.joda.time.Instant;
> +
> +/**
> + * ProtoRow extends the Row and does late materialisation. It hold a
reference to the original proto
> + * message and has an overlay on each field of the proto message. It
doesn't have it's own Coder as
> + * it relies on the SchemaCoder to (de)serialize the message over the
wire.
> + *
> + * <p>Each row has a FieldOverlay that handles specific field
conversions, as well has special
> + * overlays for Well Know Types, Repeatables, Maps and Nullables.
> + */
>
> Yes. I want to review this first though.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/beam/pull/8690?email_source=notifications&email_token=AAE4EM5RTN33LJTSVV6H6ZLPZFE2XA5CNFSM4HPXM2D2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB22KVRQ#discussion_r291299236>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AAE4EM4BC2IAUU2VEUOP2CDPZFE2XANCNFSM4HPXM2DQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 255290)
Time Spent: 2h 50m (was: 2h 40m)
> Protobuf Beam Schema support
> ----------------------------
>
> Key: BEAM-7274
> URL: https://issues.apache.org/jira/browse/BEAM-7274
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Alex Van Boxel
> Assignee: Alex Van Boxel
> Priority: Minor
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Add support for the new Beam Schema to the Protobuf extension.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
