[
https://issues.apache.org/jira/browse/BEAM-6904?focusedWorklogId=255942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-255942
]
ASF GitHub Bot logged work on BEAM-6904:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/19 14:23
Start Date: 07/Jun/19 14:23
Worklog Time Spent: 10m
Work Description: stale[bot] commented on issue #8208: [BEAM-6904] Add
tests for structuralValue implementation in coders
URL: https://github.com/apache/beam/pull/8208#issuecomment-499904605
This pull request has been marked as stale due to 60 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull request requires a review, please simply write any
comment. If closed, you can revive the PR at any time and @mention a reviewer
or discuss it on the [email protected] list. Thank you for your
contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 255942)
Time Spent: 2h 40m (was: 2.5h)
> Test all Coder structuralValue implementations
> ----------------------------------------------
>
> Key: BEAM-6904
> URL: https://issues.apache.org/jira/browse/BEAM-6904
> Project: Beam
> Issue Type: Test
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Alexander Savchenko
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Here is a test helper that check that structuralValue is consistent with
> equals:
> https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/CoderProperties.java#L200
> And here is one that tests it another way:
> https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/CoderProperties.java#L226
> With the deprecation of consistentWithEquals and implementing all the
> structualValue methods, we should add these tests to every coder.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
