[ 
https://issues.apache.org/jira/browse/BEAM-6257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859307#comment-16859307
 ] 

Kenneth Knowles commented on BEAM-6257:
---------------------------------------

Looks very close:

 - {{thatMultimap}} has one use: 
https://github.com/apache/beam/search?q=thatMultimap&unscoped_q=thatMultimap
 - {{thatMap}} has three uses: 
https://github.com/apache/beam/search?q=thatMap&unscoped_q=thatMap

In doing those searches, I notice that {{thatMap}} has a test in 
{{PAssertTest}} while {{thatMultimap}} does not have any tests.

> Can we deprecate the side input paths through PAssert?
> ------------------------------------------------------
>
>                 Key: BEAM-6257
>                 URL: https://issues.apache.org/jira/browse/BEAM-6257
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kyle Weaver
>            Priority: Major
>              Labels: starter
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> PAssert has two distinct paths - one uses GBK with a single-firing trigger, 
> and one uses side inputs. Side inputs are usually a later addition to a 
> runner, while GBK is one of the first primitives (with a single firing it is 
> even simple). Filing this against myself to figure out why the side input 
> version is not deprecated, and if it can be deprecated.
> Marking this as a "starter" task because finding and eliminating side input 
> version of PAssert should be fairly easy. You might need help but can ask on 
> dev@



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to