[
https://issues.apache.org/jira/browse/BEAM-6693?focusedWorklogId=257187&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-257187
]
ASF GitHub Bot logged work on BEAM-6693:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/19 20:43
Start Date: 10/Jun/19 20:43
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #8799: [BEAM-6693]
replace mmh3 with default hash function
URL: https://github.com/apache/beam/pull/8799#discussion_r292183173
##########
File path: sdks/python/apache_beam/transforms/stats.py
##########
@@ -214,7 +212,7 @@ def create_accumulator(self, *args, **kwargs):
Review comment:
Suggestion (Maybe add a JIRA (does not have to be fixed in this PR) for
future):
- Pass a hash_fn argument to ApproximateUniqueCombineFn, that can be passed
by users to customize the hash_fn they would like to use. It can default to
`hash`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 257187)
Time Spent: 12h 10m (was: 12h)
> ApproximateUnique transform for Python SDK
> ------------------------------------------
>
> Key: BEAM-6693
> URL: https://issues.apache.org/jira/browse/BEAM-6693
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Ahmet Altay
> Assignee: Hannah Jiang
> Priority: Minor
> Fix For: 2.14.0
>
> Time Spent: 12h 10m
> Remaining Estimate: 0h
>
> Add a PTransform for estimating the number of distinct elements in a
> PCollection and the number of distinct values associated with each key in a
> PCollection KVs.
> it should offer the same API as its Java counterpart:
> https://github.com/apache/beam/blob/11a977b8b26eff2274d706541127c19dc93131a2/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateUnique.java
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
