[
https://issues.apache.org/jira/browse/BEAM-7407?focusedWorklogId=258905&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-258905
]
ASF GitHub Bot logged work on BEAM-7407:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/19 17:14
Start Date: 12/Jun/19 17:14
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8745: [BEAM-7407]
Adds portable wordcount test for Python 3 with Flink runner.
URL: https://github.com/apache/beam/pull/8745#discussion_r293026416
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1815,6 +1815,58 @@ class BeamModulePlugin implements Plugin<Project> {
}
}
}
+
+ project.ext.addPortableWordCountTask = { String nameSuffix, boolean
isStreaming ->
Review comment:
PTAL. I couldn't find such recommendation in Groovy style guide
http://groovy-lang.org/style-guide.html. I moved the streaming parameter into
an internal helper function, and it only has 1 parameter right now. Making it
implicit requires adding another "Configuration" class, which at this point
seems unnecessary boilerplate. I agree that passing maps is better when we have
large number of parameters, similar how service requests/responses are JSON /
ProtoBufs, but I don't think we should follow this everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 258905)
Time Spent: 3h 20m (was: 3h 10m)
> Create a Wordcount-on-Flink Python 3 test suite.
> ------------------------------------------------
>
> Key: BEAM-7407
> URL: https://issues.apache.org/jira/browse/BEAM-7407
> Project: Beam
> Issue Type: Sub-task
> Components: runner-flink
> Reporter: Valentyn Tymofieiev
> Assignee: Valentyn Tymofieiev
> Priority: Blocker
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
